-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate SafeERC20.safeIncreaseAllowance and SafeERC20.safeDecreaseAllowance #5259
Deprecate SafeERC20.safeIncreaseAllowance and SafeERC20.safeDecreaseAllowance #5259
Conversation
🦋 Changeset detectedLatest commit: a26e987 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should forceApprove
also have a comment?
Co-authored-by: cairo <cairoeth@protonmail.com>
No deprecation, but a comment yes maybe |
…://github.com/Amxx/openzeppelin-contracts into 5_1_rc/erc20/deprecate_safe_increase_decrease
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of marking safeIncreaseAllowance
and safeDecreaseAllowance
as deprecated given their common usage in production contracts, so I opened #5262, which is the same but without the deprecation. I'll still approve this in case you think deprecation still makes sense despite the usage.
PR Checklist
npx changeset add
)