Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NoncesKeyed variant #5272

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Add NoncesKeyed variant #5272

merged 10 commits into from
Oct 23, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Oct 21, 2024 •
edited
Loading

Fixes #5011

Name

  • NoncesSemiAbstracted
  • SemiAbstractedNonces
  • NoncesWithKeys
  • other ?

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7fabf37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amxx Amxx requested a review from a team October 21, 2024 14:17
@Amxx Amxx added this to the 5.2 milestone Oct 21, 2024
arr00
arr00 previously approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and sufficiently tested. I do agree that the name NoncesSemiAbstracted is somewhat meaningless and would support a name change.

@Amxx
Copy link
Collaborator Author

Amxx commented Oct 22, 2024

I used the name NoncesSemiAbstracted so that it is clear that it is a variant of Nonces.

Doing SemiAbstractedNonces would not have this effect as they next to each other when sorting alphabetically.

How do you feel about NoncesWithKeys? Any other proposal?

@Amxx Amxx requested a review from arr00 October 22, 2024 16:32
arr00
arr00 previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@arr00 arr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think NoncesWithKeys is more meaningful. I don't have a strong feeling either was since EF coined this as Semi Abstracted (whatever that means).

@Amxx Amxx changed the title Add semi-abstracted nonce variant Add nonce with keys variant Oct 22, 2024
@Amxx
Copy link
Collaborator Author

Amxx commented Oct 22, 2024 •
edited
Loading

@frangio Do the last changes feel better ?

@Amxx Amxx changed the title Add nonce with keys variant Add NoncesKeyed variant Oct 22, 2024
@Amxx Amxx requested review from frangio and arr00 October 22, 2024 20:46
@frangio
Copy link
Contributor

frangio commented Oct 22, 2024 •
edited
Loading

Just seeing that you were considering the name NoncesWithKeys too. I don't have a strong preference between NoncesWithKeys and NoncesKeyed.

@Amxx Amxx merged commit 2fa4d10 into OpenZeppelin:master Oct 23, 2024
17 checks passed
@Amxx Amxx deleted the features/semi-abstracted-nonces branch October 23, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cairoeth cairoeth cairoeth approved these changes

@arr00 arr00 arr00 approved these changes

@frangio frangio frangio approved these changes

@ernestognw ernestognw Awaiting requested review from ernestognw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

Semi abstracted nonce support
4 participants
@Amxx @frangio @arr00 @cairoeth