-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement issue and pr templates #641
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
## The Problem | ||
|
||
[] π This is a bug report. | ||
[] π This is a feature request. | ||
|
||
<!-- Please check one of the above by placing an x in the box. --> | ||
|
||
Briefly describe the issue you are experiencing (or the feature you want to see added to OpenZeppelin). Tell us what you were trying to do and what happened instead. **Remember, this is _not_ a place to ask for help debugging code; for that, we welcome you in the [OpenZeppelin Slack Channel](https://slack.openzeppelin.org/).** | ||
|
||
## π» Environment | ||
|
||
First, we need to know what your environment looks like. | ||
|
||
- Which version of OpenZeppelin are you using? | ||
- What network are you deploying to? testrpc? Ganache? Ropsten? | ||
- How are you deploying your OpenZeppelin-backed contracts? truffle? Remix? Let us know! | ||
|
||
## π Details | ||
|
||
Describe the problem you have been experiencing in more detail. Include as much information as you think is relevant. Keep in mind that transactions can fail for many reasons; context is key here. | ||
|
||
## π’ Code To Reproduce Issue [ Good To Have ] | ||
|
||
Please remember that with sample code it's easier to reproduce the bug and it's much faster to fix it. | ||
|
||
``` | ||
insert short code snippets here | ||
``` | ||
|
||
<!-- If your code is larger, consider linking us to a repo illustrating your issue. --> | ||
|
||
## π Other Information | ||
<!-- List any other information that is relevant to your issue. Error logs, related issues, suggestions on how to fix, Stack Overflow links, forum links, etc. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
<!-- π Thank you for submitting a PR! Before submitting, please review the following checklist: --> | ||
|
||
- [ ] π I've reviewed the [OpenZeppelin Contributor Guidelines](/docs/CONTRIBUTING.md) | ||
- [ ] β I've added tests where applicable to test my new functionality. | ||
- [ ] π I've made sure that my contracts are well-documented. | ||
- [ ] π¨ I've run the JavaScript linter (`npm run lint:fix`) and fixed all issues. | ||
|
||
<!-- **Does this close any open issues?** If so, list them here. --> | ||
|
||
Fixes # | ||
|
||
--- | ||
|
||
# π Description | ||
|
||
<!-- Describe the changes introduced in this pull request --> | ||
<!-- Include any context necessary for understanding the PR's purpose. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this was done in this PR but Waffle didn't associate it to the corresponding issue correctly. It may be related to the lack of "fixes #639" thing mentioned above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, looks like you do need both: https://help.waffle.io/automatic-work-tracking/auto-work-tracking-basics/recommended-workflow-using-pull-requests-automatic-work-tracking