Refactoring Superuser contract to allow Owners to transfer ownership … #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when they are not superusers OpenZeppelin#50
|
In Ownable.sol I extracted the functionality of transferOwnership to an internal function and moved the renounceOwnership function above the transferOwnership function. |
4 tasks
shrugs
approved these changes
Jun 5, 2018
frangio
requested changes
Jun 5, 2018
test/ownership/Superuser.test.js
Outdated
|
|
||
| it('should change owner after the owner transfers the ownership', async function () { | ||
| await expectEvent.inTransaction( | ||
| this.superuser.transferOwnership(finalOwner, { from: newOwner }), |
There was a problem hiding this comment.
I was confused that newOwner was sending this tx, but I saw that you're using the same Superuser instance for all tests! You should create the Superuser instance in a beforeEach block instead of before, so as to have the tests be independent of one another.
Then it will be firstOwner sending this tx.
frangio
approved these changes
Jun 5, 2018
pmosse
deleted the
feature/refactor-superuser-contract-transfer-ownership-#50
branch
|
Great! @frangio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Refactor to the Superuser contract to allow owners that are not superusers to transfer the ownership of the contract.
npm run lint:all:fix).