Reduce asm in Proxy.sol #1487
Reduce asm in Proxy.sol #1487
Conversation
|
What about a new version? Or you think performance will be different and in this place it is more matter? |
|
I'm not sure I understod the question. A new version of what? Do you mean upgrading to Solidity 0.6? |
|
@frangio I mean I added new commit to handle this 😁 |
|
I really like this! I would like someone else to look at it because it's quite critical. |
| case 0 { revert(add(data, 32), returndatasize) } | ||
| default { return(add(data, 32), returndatasize) } |
There was a problem hiding this comment.
A small optimization, although the compiler may catch this too.
| case 0 { revert(add(data, 32), returndatasize) } | |
| default { return(add(data, 32), returndatasize) } | |
| let data_start := add(data, 32) | |
| case 0 { revert(data_start, returndatasize) } | |
| default { return(data_start, returndatasize) } |
I also considered using mload(data) instead of returndatasize but it seems to be more expensive.
There was a problem hiding this comment.
I tried mload(data), but tests failed
There was a problem hiding this comment.
That's interesting. Did you understand why?
There was a problem hiding this comment.
@frangio not yet, will check
No description provided.