Skip to content

Commit

Permalink
fix(app): Remove probe check from module calibration (#14154)
Browse files Browse the repository at this point in the history
* fix(app): remove probe check from module cal

Module calibration doesn't require a pipette id and thus none is
available here (and in general I believe you can do it with a gripper)
so this isn't really an appropriate check.

* this was new too whoops probably should have been a sign
  • Loading branch information
sfoster1 authored Dec 8, 2023
1 parent 8869fa1 commit 2053ac9
Showing 1 changed file with 3 additions and 28 deletions.
31 changes: 3 additions & 28 deletions app/src/organisms/ModuleWizardFlows/AttachProbe.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import {
import { Banner } from '../../atoms/Banner'
import { StyledText } from '../../atoms/text'
import { GenericWizardTile } from '../../molecules/GenericWizardTile'
import { ProbeNotAttached } from '../PipetteWizardFlows/ProbeNotAttached'

import type { ModuleCalibrationWizardStepProps } from './types'
interface AttachProbeProps extends ModuleCalibrationWizardStepProps {
Expand Down Expand Up @@ -67,12 +66,8 @@ export const AttachProbe = (props: AttachProbeProps): JSX.Element | null => {
'module_wizard_flows',
'pipette_wizard_flows',
])
const [showUnableToDetect, setShowUnableToDetect] = React.useState<boolean>(
false
)

const moduleDisplayName = getModuleDisplayName(attachedModule.moduleModel)
const pipetteId = attachedPipette.serialNumber

const attachedPipetteChannels = attachedPipette.data.channels
let pipetteAttachProbeVideoSource, probeLocation
Expand Down Expand Up @@ -159,12 +154,6 @@ export const AttachProbe = (props: AttachProbeProps): JSX.Element | null => {
setErrorMessage('calibration adapter has not been loaded yet')
return
}
const verifyCommands: CreateCommand[] = [
{
commandType: 'verifyTipPresence',
params: { pipetteId: pipetteId, expectedState: 'present' },
},
]
const homeCommands: CreateCommand[] = [
{
commandType: 'home' as const,
Expand All @@ -188,18 +177,12 @@ export const AttachProbe = (props: AttachProbeProps): JSX.Element | null => {
},
]

chainRunCommands?.(verifyCommands, false)
chainRunCommands?.(homeCommands, false)
.then(() => {
chainRunCommands?.(homeCommands, false)
.then(() => {
proceed()
})
.catch((e: Error) => {
setErrorMessage(`error starting module calibration: ${e.message}`)
})
proceed()
})
.catch((e: Error) => {
setShowUnableToDetect(true)
setErrorMessage(`error starting module calibration: ${e.message}`)
})
}

Expand All @@ -225,14 +208,6 @@ export const AttachProbe = (props: AttachProbeProps): JSX.Element | null => {
)}
</InProgressModal>
)
else if (showUnableToDetect)
return (
<ProbeNotAttached
handleOnClick={handleBeginCalibration}
setShowUnableToDetect={setShowUnableToDetect}
isOnDevice={isOnDevice ?? false}
/>
)
// TODO: add calibration loading screen and error screen
else
return (
Expand Down

0 comments on commit 2053ac9

Please sign in to comment.