move navigate out of props

Opentrons · Oct 21, 2024 · bb306f3 · bb306f3
1 parent 53d8f40
commit bb306f3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/...rganisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderBannerContainer/index.tsx b/...rganisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderBannerContainer/index.tsx
@@ -1,4 +1,5 @@
 import { useTranslation } from 'react-i18next'
+import { useNavigate } from 'react-router-dom'
 
 import {
   Box,
@@ -34,24 +35,24 @@ export type RunHeaderBannerContainerProps = ProtocolRunHeaderProps & {
   runErrors: UseRunErrorsResult
   runHeaderModalContainerUtils: UseRunHeaderModalContainerResult
   hasDownloadableFiles: boolean
-  deviceDetailsLink: () => void
 }
 
 // Holds all the various banners that render in ProtocolRunHeader.
 export function RunHeaderBannerContainer(
   props: RunHeaderBannerContainerProps
 ): JSX.Element | null {
+  const navigate = useNavigate()
   const {
     runStatus,
     enteredER,
     runHeaderModalContainerUtils,
     hasDownloadableFiles,
-    deviceDetailsLink,
+    robotName,
   } = props
   const { analysisErrorModalUtils } = runHeaderModalContainerUtils
 
   const { t } = useTranslation(['run_details', 'shared'])
-  const isDoorOpen = useIsDoorOpen(props.robotName)
+  const isDoorOpen = useIsDoorOpen(robotName)
 
   const {
     showRunCanceledBanner,
@@ -114,7 +115,9 @@ export function RunHeaderBannerContainer(
             </Flex>
             <Link
               textDecoration={TEXT_DECORATION_UNDERLINE}
-              onClick={deviceDetailsLink}
+              onClick={() => {
+                navigate(`/devices/${robotName}`)
+              }}
             >
               {t('device_details')}
             </Link>

diff --git a/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/index.tsx b/app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/index.tsx
@@ -108,9 +108,6 @@ export function ProtocolRunHeader(
             'outputFileIds' in runRecord.data &&
             runRecord.data.outputFileIds.length > 0
           }
-          deviceDetailsLink={() => {
-            navigate(`/devices/${robotName}`)
-          }}
           {...props}
         />
         <RunHeaderContent