-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design QA: Liquid Labware Modal / Generalize Modal Component #11142
Comments
@mmencarelli This modal is currently centered within the entire window, including the left nav bar. Do you want it centered on the screen excluding the nav bar? |
@smb2268 Let's have it centered within the viewport (entire window - navbar). As the user slowly starts to shrink screen size it'll overlap the navbar like we see below at 800px wide. |
smb2268
added a commit
that referenced
this issue
Jul 25, 2022
smb2268
added a commit
that referenced
this issue
Jul 27, 2022
smb2268
added a commit
that referenced
this issue
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We want to move away from using
BaseModal
in the Modal organism. To generalize and streamline modals going forward, we're going to make the following components:ModalShell
component whichModalTitle
component which will be used as the header in most cases withThis ticket will:
See this loom: https://www.loom.com/share/5b4c97dae1784ebabc6dc0c4199f61b6
The text was updated successfully, but these errors were encountered: