fix(app-shell, app-shell-odd): Prevent excessive notify logs #14582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because subscription logic is handled by components currently, logs are excessive in some spots, especially on the OT-2. Let's comment out the logs until we refactor subscription logic to be handled directly by the robot-server.
…ice is a Flex The app-shell/app-shell-odd properly handles when the robot should (or should not) connect, however, we already use isFlex within the app, so we might as well save OT-2s the trouble of talking to the app-shell. This won't be any extra effort to refactor once OT-2s support MQTT.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.2.0 #14582 +/- ##
=======================================================
- Coverage 67.60% 67.57% -0.03%
=======================================================
Files 2521 2521
Lines 72212 72252 +40
Branches 9289 9322 +33
=======================================================
+ Hits 48818 48824 +6
- Misses 21204 21238 +34
Partials 2190 2190
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ncdiehl11
approved these changes
Mar 1, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-2431
Overview
Because subscription logic is handled by components currently, logs are excessive in some spots, especially on the OT-2. Let's comment out the logs until we refactor subscription logic to be handled directly by the robot-server (next release). Note that there aren't any excessive network requests - it's just logs.
Test Plan
Changelog
Risk assessment
low