Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-shell, app-shell-odd): Prevent excessive notify logs #14582

Merged
merged 6 commits into from
Mar 1, 2024
Merged

fix(app-shell, app-shell-odd): Prevent excessive notify logs #14582

merged 6 commits into from
Mar 1, 2024

Commits on Mar 1, 2024

  1. refactor(app-shell, app-shell-odd): comment out chatty logs for now 

    Because subscription logic is handled by components currently, logs are excessive in some spots,
especially on the OT-2. Let's comment out the logs until we refactor subscription logic to be
handled directly by the robot-server.
    @mjhuff
    mjhuff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5144e68 View commit details
    Browse the repository at this point in the history

  2. refactor(app): don't try using notifications notifications unless dev… 

    …ice is a Flex

The app-shell/app-shell-odd properly handles when the robot should (or should not) connect, however,
we already use isFlex within the app, so we might as well save OT-2s the trouble of talking to the
app-shell. This won't be any extra effort to refactor once OT-2s support MQTT.
    @mjhuff
    mjhuff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    747a4a8 View commit details
    Browse the repository at this point in the history

  3. one more log to be safe

    @mjhuff
    mjhuff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    2b3fe50 View commit details
    Browse the repository at this point in the history

  4. let's be safe and not make this assumption

    @mjhuff
    mjhuff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    ad734da View commit details
    Browse the repository at this point in the history

  5. let's be extra safe

    @mjhuff
    mjhuff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    86ad7aa View commit details
    Browse the repository at this point in the history

  6. and a final safety measure

    @mjhuff
    mjhuff committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    760926f View commit details
    Browse the repository at this point in the history