-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hardware): move scheduler #13026
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #13026 +/- ##
==========================================
- Coverage 72.45% 72.42% -0.03%
==========================================
Files 2388 2390 +2
Lines 66012 66029 +17
Branches 7319 7332 +13
==========================================
- Hits 47829 47824 -5
- Misses 16443 16466 +23
+ Partials 1740 1739 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, but I think for readability wins it has to be taken a bit farther - get the runner all the way out of the business of iterating through things based on node+seq; maybe make that the responsibility of something new replacing self._moves
or something. Ideally we should start with the concept of factoring out some chunk of responsibility and making it a separately-testable thing.
Also, we should wait until 0.13.0 is in to merge thi; there's a lot of changes to this code in there.
9c1003e
to
8a58315
Compare
8a58315
to
e227728
Compare
Bit off too much by trying to put everything in this giant refactor - closing this and splitting it up into smaller PRs instead |
Overview
Test Plan
Changelog
Review requests
Risk assessment