Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware-testing): Gravimetric "daily-setup" script for confirming fixture stability and accuracy #13876

Merged
merged 20 commits into from
Nov 1, 2023

Conversation

andySigler
Copy link
Contributor

Overview

This PR adds a script hardware_testing.gravimetric.daily_setup, intended to be used each morning in the factory, to confirm each individual gravimetric fixture's stability and accuracy.

The script does the following:

  • Check fixture stability while gantry moves
  • Check fixture stability while operator walks around it
  • Zero the scale
  • Calibrate the scale (aka: "internal-adjustment")
  • Confirm accuracy using an external weight

Some minor changes were also made to the plot webpage, most notably adding buttons to make it easier to select which test should be displayed.

Test Plan

Changelog

Review requests

Risk assessment

@andySigler andySigler requested review from a team as code owners October 31, 2023 11:42
@andySigler andySigler requested review from TamarZanzouri and removed request for a team October 31, 2023 11:42
@andySigler andySigler changed the title feat(hardware-testing): Gravimetric "daily-setup" script to confirming fixture stability and accuracy feat(hardware-testing): Gravimetric "daily-setup" script for confirming fixture stability and accuracy Oct 31, 2023
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #13876 (678a620) into edge (7d68d92) will not change coverage.
Report is 14 commits behind head on edge.
The diff coverage is n/a.

❗ Current head 678a620 differs from pull request most recent head 1b29ad2. Consider uploading reports for the commit 1b29ad2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #13876   +/-   ##
=======================================
  Coverage   70.82%   70.82%           
=======================================
  Files        2498     2498           
  Lines       70181    70181           
  Branches     8589     8589           
=======================================
  Hits        49709    49709           
  Misses      18383    18383           
  Partials     2089     2089           

@andySigler andySigler merged commit 5dc8819 into edge Nov 1, 2023
13 checks passed
@andySigler andySigler deleted the testing-SZ-411 branch November 1, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants