-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hardware-testing): Gravimetric "daily-setup" script for confirming fixture stability and accuracy #13876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andySigler
requested review from
TamarZanzouri
and removed request for
a team
October 31, 2023 11:42
andySigler
changed the title
feat(hardware-testing): Gravimetric "daily-setup" script to confirming fixture stability and accuracy
feat(hardware-testing): Gravimetric "daily-setup" script for confirming fixture stability and accuracy
Oct 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13876 +/- ##
=======================================
Coverage 70.82% 70.82%
=======================================
Files 2498 2498
Lines 70181 70181
Branches 8589 8589
=======================================
Hits 49709 49709
Misses 18383 18383
Partials 2089 2089 |
ryanthecoder
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a script
hardware_testing.gravimetric.daily_setup
, intended to be used each morning in the factory, to confirm each individual gravimetric fixture's stability and accuracy.The script does the following:
Some minor changes were also made to the plot webpage, most notably adding buttons to make it easier to select which test should be displayed.
Test Plan
Changelog
Review requests
Risk assessment