Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix choose robot slideout for usb #13897

Merged

Conversation

shlokamin
Copy link
Member

@shlokamin shlokamin commented Nov 1, 2023

Overview

This PR fixes the shoose a robot slideout when sending a protocol to a Flex and starting a protocol run on a Flex over usb.

Test Plan

  • Verified that I could send a protocol/start a protocol run on a Flex over USB
  • Verified that I could send a protocol/start a protocol run on a Flex over the network

Changelog

  • Fix choose robot slideout for usb

Risk assessment

Low/med

@shlokamin shlokamin marked this pull request as ready for review November 1, 2023 22:30
@shlokamin shlokamin requested a review from a team as a code owner November 1, 2023 22:30
@shlokamin shlokamin requested review from ncdiehl11 and brenthagen and removed request for a team November 1, 2023 22:30
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #13897 (8d5ceaa) into chore_release-7.0.2 (85369e7) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.0.2   #13897      +/-   ##
=======================================================
  Coverage                71.21%   71.22%              
=======================================================
  Files                     2432     1589     -843     
  Lines                    68443    52790   -15653     
  Branches                  8053     3458    -4595     
=======================================================
- Hits                     48741    37599   -11142     
+ Misses                   17815    14656    -3159     
+ Partials                  1887      535    -1352     
Flag Coverage Δ
app 43.04% <ø> (-25.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 843 files with indirect coverage changes

@shlokamin shlokamin merged commit 9ff5a6a into chore_release-7.0.2 Nov 1, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants