Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app, api-client): add utilities for parsing deck config via addressable areas #13947

Merged
merged 6 commits into from
Nov 9, 2023

fix up tests and remove improper v7 type

659cfb4
Select commit
Loading
Failed to load commit list.
Merged

refactor(app, api-client): add utilities for parsing deck config via addressable areas #13947

fix up tests and remove improper v7 type
659cfb4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2023 in 1s

70.49% (-0.34%) compared to c4b3b56

View this Pull Request on Codecov

70.49% (-0.34%) compared to c4b3b56

Details

Codecov Report

Merging #13947 (659cfb4) into edge (c4b3b56) will decrease coverage by 0.34%.
Report is 32 commits behind head on edge.
The diff coverage is 58.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #13947      +/-   ##
==========================================
- Coverage   70.82%   70.49%   -0.34%     
==========================================
  Files        2504     2509       +5     
  Lines       70465    72211    +1746     
  Branches     8616     9226     +610     
==========================================
+ Hits        49908    50906     +998     
- Misses      18457    19057     +600     
- Partials     2100     2248     +148     
Files Coverage Δ
...rc/organisms/ProtocolSetupModulesAndDeck/index.tsx 67.94% <ø> (ø)
protocol-designer/src/load-file/migration/8_0_0.ts 81.25% <ø> (+1.25%) ⬆️
app/src/organisms/CommandText/LoadCommandText.tsx 54.76% <0.00%> (-1.34%) ⬇️
.../Devices/ProtocolRun/utils/getLabwareRenderInfo.ts 76.66% <0.00%> (-3.34%) ⬇️
...InterventionModal/utils/getRunLabwareRenderInfo.ts 83.33% <0.00%> (-5.56%) ⬇️
shared-data/js/helpers/index.ts 74.21% <80.00%> (-0.39%) ⬇️
.../Devices/ProtocolRun/utils/getLocationInfoNames.ts 54.05% <0.00%> (-3.09%) ⬇️
...rc/organisms/LabwarePositionCheck/utils/labware.ts 14.43% <0.00%> (-0.16%) ⬇️
...ocol-designer/src/labware-ingred/reducers/index.ts 22.36% <0.00%> (-0.61%) ⬇️
...yHistoricOffsets/hooks/getLabwareLocationCombos.ts 21.66% <0.00%> (-1.15%) ⬇️
... and 3 more

... and 68 files with indirect coverage changes