Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): always enable BackToTop button #14103

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Dec 6, 2023

closes RQA-1954

Overview

Remove checks for disabling BackToTop button at the last setup step and remove hover tooltips for disabled reason. The user should always be enabled to click BackToTop in ProtocolRun even if proceeding to run is disabled.

Note: I set the disabled prop for the button to always false because the only time component is rendered is within ProtocolRun. If we utilize the button elsewhere, we can add a prop for disabling.

Test Plan

  • Proceed to protocol setup that should not be ready to run (missing calibrations, incorrect pipettes, etc.)
  • Observe that the BackToTop button renders after the last setup step and is enabled.

Changelog

  • remove disabling BackToTop inside component
  • update tests to always expect the button to be enabled

Risk assessment

low

Remove checks for disabling BackToTop button at the last setup step and remove hover tooltips for
disabled reason. The user should always be enabled to click BackToTop in protocol setup even if
proceeding to run is disabled.
@ncdiehl11 ncdiehl11 requested review from a team as code owners December 6, 2023 15:20
@ncdiehl11 ncdiehl11 requested review from shlokamin and removed request for a team December 6, 2023 15:20
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #14103 (6060a8f) into chore_release-7.1.0 (7749f36) will decrease coverage by 0.02%.
Report is 8 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14103      +/-   ##
=======================================================
- Coverage                70.44%   70.42%   -0.02%     
=======================================================
  Files                     1636     2512     +876     
  Lines                    54474    71232   +16758     
  Branches                  4008     8975    +4967     
=======================================================
+ Hits                     38373    50167   +11794     
- Misses                   15407    18872    +3465     
- Partials                   694     2193    +1499     
Flag Coverage Δ
app 67.55% <ø> (+28.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../organisms/Devices/ProtocolRun/BackToTopButton.tsx 100.00% <ø> (ø)

... and 879 files with indirect coverage changes

@ncdiehl11 ncdiehl11 changed the base branch from edge to chore_release-7.1.0 December 6, 2023 15:20
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, BackToTopButton test suite can be cleaned up a little bit. I think lines 28-37 can be deleted since we no longer need those mocks.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for cleaning up the test 🦕

@ncdiehl11 ncdiehl11 merged commit 5ec4263 into chore_release-7.1.0 Dec 6, 2023
22 checks passed
@ncdiehl11 ncdiehl11 deleted the app_fix-backtotop-always-enable branch December 6, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants