fix(app): filter lpc labware combos by single slot #14120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filters the labware location combos generated by getLabwareLocationCombos by Flex or OT-2 single slot addressable area name, to exclude labware in staging area slots as LPC options closes RQA-1989
brenthagen
requested review from
TamarZanzouri,
a team and
jerader
and removed request for
a team,
TamarZanzouri and
jerader
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.1.0 #14120 +/- ##
=======================================================
+ Coverage 70.44% 70.47% +0.03%
=======================================================
Files 2483 2512 +29
Lines 70328 71214 +886
Branches 8770 8965 +195
=======================================================
+ Hits 49542 50188 +646
- Misses 18635 18835 +200
- Partials 2151 2191 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
filters the labware location combos generated by
getLabwareLocationCombosby Flex or OT-2 single slot addressable area name, to exclude labware in staging area slots as LPC optionscloses RQA-1989
Test Plan
Changelog
Review requests
check LPC on Flex and OT-2 - labware in staging area slots should not be available. confirm nothing else is broken
Risk assessment
low