Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): Remove probe check from module calibration #14154

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix(app): Remove probe check from module calibration #14154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c9a9a
fix(app): remove probe check from module cal
sfoster1 Dec 8, 2023
3dee992
this was new too whoops probably should have been a sign
sfoster1 Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 3 additions & 28 deletions app/src/organisms/ModuleWizardFlows/AttachProbe.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import { Banner } from '../../atoms/Banner'
import { StyledText } from '../../atoms/text'
import { GenericWizardTile } from '../../molecules/GenericWizardTile'
import { ProbeNotAttached } from '../PipetteWizardFlows/ProbeNotAttached'

import type { ModuleCalibrationWizardStepProps } from './types'
interface AttachProbeProps extends ModuleCalibrationWizardStepProps {
Expand Down Expand Up @@ -67,12 +66,8 @@
'module_wizard_flows',
'pipette_wizard_flows',
])
const [showUnableToDetect, setShowUnableToDetect] = React.useState<boolean>(
false
)

const moduleDisplayName = getModuleDisplayName(attachedModule.moduleModel)
const pipetteId = attachedPipette.serialNumber

const attachedPipetteChannels = attachedPipette.data.channels
let pipetteAttachProbeVideoSource, probeLocation
Expand Down Expand Up @@ -159,12 +154,6 @@
setErrorMessage('calibration adapter has not been loaded yet')
return
}
const verifyCommands: CreateCommand[] = [
{
commandType: 'verifyTipPresence',
params: { pipetteId: pipetteId, expectedState: 'present' },
},
]
const homeCommands: CreateCommand[] = [
{
commandType: 'home' as const,
Expand All @@ -188,18 +177,12 @@
},
]

chainRunCommands?.(verifyCommands, false)
chainRunCommands?.(homeCommands, false)

Check warning on line 180 in app/src/organisms/ModuleWizardFlows/AttachProbe.tsx

View check run for this annotation

Codecov / codecov/patch

app/src/organisms/ModuleWizardFlows/AttachProbe.tsx#L180 

Added line #L180 was not covered by tests
.then(() => {
chainRunCommands?.(homeCommands, false)
.then(() => {
proceed()
})
.catch((e: Error) => {
setErrorMessage(`error starting module calibration: ${e.message}`)
})
proceed()

Check warning on line 182 in app/src/organisms/ModuleWizardFlows/AttachProbe.tsx

View check run for this annotation

Codecov / codecov/patch

app/src/organisms/ModuleWizardFlows/AttachProbe.tsx#L182 

Added line #L182 was not covered by tests
})
.catch((e: Error) => {
setShowUnableToDetect(true)
setErrorMessage(`error starting module calibration: ${e.message}`)

Check warning on line 185 in app/src/organisms/ModuleWizardFlows/AttachProbe.tsx

View check run for this annotation

Codecov / codecov/patch

app/src/organisms/ModuleWizardFlows/AttachProbe.tsx#L185 

Added line #L185 was not covered by tests
})
}

Expand All @@ -225,14 +208,6 @@
)}
</InProgressModal>
)
else if (showUnableToDetect)
return (
<ProbeNotAttached
handleOnClick={handleBeginCalibration}
setShowUnableToDetect={setShowUnableToDetect}
isOnDevice={isOnDevice ?? false}
/>
)
// TODO: add calibration loading screen and error screen
else
return (
Expand Down
Loading