Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Copy fixes in app flows #14167

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Dec 11, 2023

RQA-2048, RQA-2016, RQA-2023

Overview

This PR fixes a few small copy related bugs

Test Plan

Tested all of these out:
Screen Shot 2023-12-11 at 5 16 30 PM
Screen Shot 2023-12-11 at 5 13 59 PM
Screen Shot 2023-12-11 at 5 06 57 PM

Changelog

  1. Change firmware copy to say "No firmware update found" within pipette attachment modal so that if no pipette is attached the copy isn't confusing
  2. Fix bold i18n key in attach probe step of module calibration
  3. Show "Both mounts" for 96 channel pipette in protocol details

Review requests

Sanity check code

Risk assessment

Low

@smb2268 smb2268 self-assigned this Dec 11, 2023
@smb2268 smb2268 requested a review from a team as a code owner December 11, 2023 22:17
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #14167 (2e4fa27) into chore_release-7.1.0 (f7caea6) will increase coverage by 0.00%.
Report is 6 commits behind head on chore_release-7.1.0.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           chore_release-7.1.0   #14167   +/-   ##
====================================================
  Coverage                70.45%   70.46%           
====================================================
  Files                     2512     2512           
  Lines                    71217    71216    -1     
  Branches                  8971     8970    -1     
====================================================
+ Hits                     50177    50180    +3     
+ Misses                   18844    18842    -2     
+ Partials                  2196     2194    -2     
Flag Coverage Δ
app 67.67% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pp/src/organisms/ModuleWizardFlows/AttachProbe.tsx 6.52% <ø> (ø)
...isms/ProtocolDetails/RobotConfigurationDetails.tsx 81.48% <75.00%> (+2.91%) ⬆️

... and 2 files with indirect coverage changes

@@ -20,7 +20,7 @@
"labware": "labware",
"last_analyzed": "last analyzed",
"last_updated": "last updated",
"left_and_right_mounts": "Left+Right Mounts",
"left_and_right_mounts": "Both Mounts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit
maybe change the name to both_mounts

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smb2268 smb2268 merged commit f813b79 into chore_release-7.1.0 Dec 12, 2023
22 checks passed
@smb2268 smb2268 deleted the app_flow-copy-fixes branch December 12, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants