Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): make API version dynamic #14268

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

erictleung
Copy link
Contributor

Overview

This commit replaces the hard-coded version number with a variable in the reStructuredText-rendered documentation landing page.

Test Plan

N/A (only touches documentation and I mirrored the format for the OT-2 tab from the Flex tab)

Changelog

  • Replace hard-coded version in docs with reStructuredText variable

Review requests

N/A

Risk assessment

Low risk

This commit replaces the hard-coded version number with a variable.
@erictleung erictleung requested a review from a team as a code owner December 28, 2023 06:45
@SyntaxColoring SyntaxColoring self-assigned this Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (13e2c40) 68.06% compared to head (852aba1) 68.06%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #14268   +/-   ##
=======================================
  Coverage   68.06%   68.06%           
=======================================
  Files        2508     2508           
  Lines       71333    71333           
  Branches     9060     9060           
=======================================
  Hits        48556    48556           
  Misses      20674    20674           
  Partials     2103     2103           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)
notify-server 89.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction!

@SyntaxColoring SyntaxColoring merged commit 40fcc34 into Opentrons:edge Jan 2, 2024
23 checks passed
@erictleung erictleung deleted the fix-api-version-ref branch January 2, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants