Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc:) update python version from 3.7 to 3.10 #14300

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Jan 9, 2024

Overview

update python version from 3.7 to 3.10 in the dev setup related docs.

Test Plan

Changelog

Review requests

Risk assessment

low

change python version from 3.7 to 3.10 in DEV_SETUP
@koji koji requested a review from ecormany January 9, 2024 05:31
@koji koji marked this pull request as ready for review January 9, 2024 05:31
@koji koji requested a review from a team as a code owner January 9, 2024 05:31
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense. Just check which patch version of Python 3.10 we're recommending. If it's not the latest available, we should say so.

DEV_SETUP.md Outdated
Comment on lines 127 to 130
Now, install the required version of Python. Use the latest available version of `3.10.x`, which is `3.10.6` at the time of writing.

```shell
pyenv install 3.7.15
pyenv install 3.10.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using Python 3.10.13 with pyenv and the monorepo since we made this change.

@koji koji requested a review from ecormany January 9, 2024 15:44
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Koji!

@koji koji merged commit 8b939ed into edge Jan 9, 2024
6 checks passed
@koji koji deleted the doc_change-python-version-to-310 branch January 9, 2024 15:51
mjhuff pushed a commit that referenced this pull request Jan 23, 2024
* docs(doc): change python version from 3.7 to 3.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants