Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app-testing): shorten shapshot filename #14306

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix(app-testing): shorten shapshot filename #14306

merged 1 commit into from
Jan 10, 2024

Conversation

y3rsh
Copy link
Collaborator

@y3rsh y3rsh commented Jan 10, 2024

Overview

  • On Windows the app-testing analyses snapshot files exceed the 260 character limit on filename.
  • We could git config --system core.longpaths true but this would mean if you clone on a Windows machine without this setting it would fail.
  • Instead, hash the test file name as the test id.
  • In a future PR make a better mapping for troubleshooting which was why the filenames were being used in the first place.

Test

Failed

image

Worked

image

Risk assessment

None, testing code.

@y3rsh y3rsh requested review from a team as code owners January 10, 2024 17:59
@y3rsh y3rsh self-assigned this Jan 10, 2024
SyntaxColoring
SyntaxColoring approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@y3rsh y3rsh merged commit 6a0e3fe into edge Jan 10, 2024
13 checks passed
@y3rsh y3rsh deleted the fix-too-long-filenames branch January 10, 2024 18:04
mjhuff pushed a commit that referenced this pull request Jan 23, 2024
@y3rsh
fix(app-testing): shorten shapshot filename (#14306)
381762a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxColoring SyntaxColoring SyntaxColoring approved these changes

Assignees

@y3rsh y3rsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@y3rsh @SyntaxColoring