fix(app): open external links in browser

[shlokamin]

Overview

This PR fixes a bug introduced by updating electron where we were opening up external links in the electron window rather than an external browser window.

As per the (poorly worded) docs, contents.setWindowOpenHandler is...

Called before creating a window a new window is requested by the renderer, e.g. by window.open(), a link with target="_blank", shift+clicking on a link, or submitting a form with

So the checks we were doing before are unnecessary.

closes RQA-2309

Test Plan

Verified internal links do not open in the browser, and verified external links do.

Changelog

• Open external links in the browser (outside of electron)

Review requests

Click around the app and make sure internal/external links work as expected.

Risk assessment

Low

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ae4e2e3) 67.70% compared to head (37c71d1) 67.77%.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14447      +/-   ##
=======================================================
+ Coverage                67.70%   67.77%   +0.07%     
=======================================================
  Files                     1628     2518     +890     
  Lines                    54907    71969   +17062     
  Branches                  4148     9244    +5096     
=======================================================
+ Hits                     37173    48778   +11605     
- Misses                   17044    20989    +3945     
- Partials                   690     2202    +1512     

Flag	Coverage Δ
app	64.58% <0.00%> (+30.69%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
app-shell/src/ui.ts	0.00% <0.00%> (ø)

... and 890 files with indirect coverage changes

[sfoster1]

nice!