Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix RecentRunProtocolCard redirecting to /protocols before /runs/:runId/setup #14486

Merged

Commits on Feb 13, 2024

  1. fix(app): fix RecentRunProtocolCard redirecting to /protocols before …

    …/runs/:runId/setup
    
    Notification changes uncovered a bug in which a RecentRunProtocolCard caused redirection to the
    /runs/:runId/setup page before the actual run had loaded, which caused the TopLevelRedirect hook to
    bounce back to the /protocols page until the run loads. Instead of relying on run within
    TopLevelRedirect for this one off route case, move the redirect within ProtocolSetup and redirect if
    run status is stopped. This creates the same end behavior without the temporary redirect to
    /protocols.
    mjhuff committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    529efc5 View commit details
    Browse the repository at this point in the history