Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix instrument detail overflow recalibration #14556

Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 27, 2024

Closes RQA-2394

Overview

This PR fixes a bug in which launching the recalibrate and drop tip flows from the ODD Instruments > [Select Pipette] > Overflow Menu > [Flow] was not working correctly.

The prop was not passed into the component following the correct pattern required for Nice Modal React.

Current Behavavior

2_27 recalibrate via ODD doesn't work

With Fix

Screen.Recording.2024-02-27.at.1.47.45.PM.mov

Test Plan

  • Verified flows now launch correctly on the ODD.

Changelog

  • Launching recalibration and Drop Tip from the ODD Instrument > Pipette > Overflow Menu now works correctly.

Review requests

  • Verify on a physical robot!

Risk assessment

low

@mjhuff mjhuff requested review from koji and a team February 27, 2024 18:48
@mjhuff mjhuff requested a review from a team as a code owner February 27, 2024 18:48
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.59%. Comparing base (10c0e77) to head (a5ab4d5).
Report is 4 commits behind head on chore_release-7.2.0.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.2.0   #14556      +/-   ##
=======================================================
- Coverage                67.74%   67.59%   -0.16%     
=======================================================
  Files                     2517     2522       +5     
  Lines                    72154    72562     +408     
  Branches                  9291     9383      +92     
=======================================================
+ Hits                     48882    49045     +163     
- Misses                   21052    21286     +234     
- Partials                  2220     2231      +11     
Flag Coverage Δ
app 64.05% <100.00%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../InstrumentDetail/InstrumentDetailOverflowMenu.tsx 80.76% <100.00%> (-3.85%) ⬇️

... and 18 files with indirect coverage changes

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjhuff mjhuff merged commit 98f0280 into chore_release-7.2.0 Feb 27, 2024
30 checks passed
@mjhuff mjhuff deleted the app_fix-instrument-detail-overflow-recal branch February 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants