Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): make on device display deck configurator updates live #15202

Merged
merged 7 commits into from
May 16, 2024

Conversation

b-cooper
Copy link
Contributor

@b-cooper b-cooper commented May 16, 2024

Overview

Instead of the previous method of staging a batch of changes to deck configuration before commiting
them with the confirm button, to avoid synchronization issues, make the ODD deck configurator behave
like the desktop version. all updates immediately permeate to the robot's source of truth

Re: https://opentrons.atlassian.net/browse/RQA-2669

Review requests

Updating deck configuration from the 3-dot menu on the ODD should be visible on every client as soon as any fixture is added or removed. The same should go for updates that originate from a desktop client editing the same robot's deck config.

Risk assessment

low

Instead of the previous method of staging a batch of changes to deck configuration before commiting
them with the confirm button, to avoid synchronization issues, make the ODD deck configurator behave
like the desktop version. all updates immediately permeate to the robot's source of truth
@b-cooper b-cooper marked this pull request as ready for review May 16, 2024 19:39
@b-cooper b-cooper requested a review from a team as a code owner May 16, 2024 19:39
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ODD/desktop, changes make sense to me

@b-cooper b-cooper merged commit bb1f1ce into chore_release-7.3.0 May 16, 2024
20 checks passed
@b-cooper b-cooper deleted the app_deck-config-odd-live-changes branch May 16, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants