Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release-notes.md #16182

Closed
wants to merge 1 commit into from

Conversation

alexjoel42
Copy link
Contributor

@alexjoel42 alexjoel42 commented Sep 3, 2024

taking this out of Slack

Overview

The original communication is kind-of untrue. You can apply LPC to RTP CSV protocols.

Test Plan and Hands on Testing

N/A

Changelog

Just changing the release notes slightly

Review requests

@ecormany confirming that the language is worth changing.

Risk assessment

It's a bit wordy and still this concept is going to be pretty tricky to communicate

Previously saved labware offsets can't be applied to protocols that require selecting a CSV file as a runtime parameter value. Run Labware Position Check freshly every time, unless you are rerunning something from the touch screen with already saved labware offsets and unchanged parameters.

Easier to maybe be a little bit less precise and more concise.

taking this out of Slack
@alexjoel42 alexjoel42 requested a review from a team as a code owner September 3, 2024 20:41
@alexjoel42 alexjoel42 requested review from smb2268 and removed request for a team September 3, 2024 20:41
Copy link
Contributor

@ecormany ecormany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this wording change is meaningful, and it actually hides the two workarounds to the issue that we're proposing:

  • Write a clever protocol that obviates the issue. or
  • Run LPC always.

The issue here is that the Apply labware offset data checkbox in the app does nothing or doesn't do what the user expects.

I would consider adding the word Stored at the beginning of the first sentence. But it's also true that you can't LPC any of your labware until the CSV is added and analysis passes.

@alexjoel42
Copy link
Contributor Author

alexjoel42 commented Sep 3, 2024

I would consider adding the word Stored at the beginning of the first sentence. But it's also true that you can't LPC any of your labware until the CSV is added and the analysis passes.

I like that comment a lot. While you clarified later in the paragraph, I saw " labware offsets can't be applied to protocols" and promptly lost track of the rest of the paragraph.

  • Stored labware offsets can't be applied to protocols that require selecting a CSV file as a runtime parameter value. Write the protocol in such a way that it passes analysis with or without the CSV file, or run Labware Position Check after confirming parameter values.

Would be stronger/truer to me.

@ecormany
Copy link
Contributor

ecormany commented Sep 4, 2024

Incorporated the small change we settled on as part of #16192.

@ecormany ecormany closed this Sep 4, 2024
y3rsh pushed a commit that referenced this pull request Sep 18, 2024
# Overview

`8.0.0_release_notes_final_final(2).md`

## Test Plan and Hands on Testing

n/a

## Changelog

- 3 new known issues for:
  - https://opentrons.atlassian.net/browse/RQA-2933
  - https://opentrons.atlassian.net/browse/EXEC-660
  - https://opentrons.atlassian.net/browse/RQA-3129
- wording change per resolution of discussion on #16182

## Review requests

The @y3rsh seal of approval.

## Risk assessment

none.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants