Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix undismissable calibration modals after e-stop event #16216

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Sep 9, 2024

Closes RQA-3155

Overview

If you throw an estop event during pipette or gripper calibration flows, the "exit" button in the modal header does not properly fire the onClose event, making it impossible to exit the modal. Currently, onClose requires the home command to succeed in order to close the modal. Instead, let's just make the modal close regardless of whether the home command succeeds or fails.

Note that module calibration flows already have this logic, it's just these two flows that don't.

Test Plan and Hands on Testing

  • Verified the modal closes after reproing the steps outlined in the linked ticket.

Changelog

  • It's now possible to exit the pipette and gripper calibration flows after an e-stop event occurs.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner September 9, 2024 14:05
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, perfect. Thanks!

@mjhuff mjhuff merged commit 877d5a5 into chore_release-8.0.0 Sep 9, 2024
26 checks passed
@mjhuff mjhuff deleted the app_fix-estop-during-cal-modal-exit branch September 9, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants