fix(app): fix undismissable calibration modals after e-stop event #16216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3155
Overview
If you throw an estop event during pipette or gripper calibration flows, the "exit" button in the modal header does not properly fire the
onClose
event, making it impossible to exit the modal. Currently,onClose
requires thehome
command to succeed in order to close the modal. Instead, let's just make the modal close regardless of whether thehome
command succeeds or fails.Note that module calibration flows already have this logic, it's just these two flows that don't.
Test Plan and Hands on Testing
Changelog
Risk assessment
low