Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): initialize disposal volume field with correct value #16219

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Sep 9, 2024

fix RQA-3158

Overview

We were initializing the input field for disposal volume with state.volume instead of state.disposalVolume - I updated that in this PR

Test Plan and Hands on Testing

Set a disposal volume that is different than the volume per well
Re-enter the pipette path setting and see that when you get to the disposal volume step, the previously set volume persists instead of the volume per well
See that pipette path setting copy now includes unit for disposal volume

Changelog

  1. Initialize input field with state.disposalVolume
  2. Add uL unit to pipette path string

Review requests

Quick code check and test

Risk assessment

Low

@smb2268 smb2268 requested review from vegano1 and a team September 9, 2024 16:21
@smb2268 smb2268 self-assigned this Sep 9, 2024
@smb2268 smb2268 requested a review from a team as a code owner September 9, 2024 16:21
@smb2268 smb2268 requested review from TamarZanzouri and removed request for a team September 9, 2024 16:21
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@smb2268 smb2268 merged commit 7002fac into chore_release-8.0.0 Sep 9, 2024
26 checks passed
@smb2268 smb2268 deleted the app_qt-disposal-volume branch September 9, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants