Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): fix ODD drop tip modal overflow not dismissing #16263

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Sep 16, 2024

Overview

Thank you @CaseyBatten for reporting this!

On the ODD, if you go to Instruments > Overflow Menu > Drop tips, the overflow menu modal renders above the drop tip wizard.

This required a good bit of playing around with to find an adequate solution, but relocating the modal rendering outside of the nice-modal provider works without too systemic of a change. Unfortunately, there are just too many conflicting modals now, and this is just another sign we should tackle this more thoroughly in the future.

Test Plan and Hands on Testing

  • On the ODD, go to Instruments > Overflow Menu > Drop tips. You should see that the overflow menu dismisses, and the modal renders appropriately.

Changelog

  • Fixed the ODD instrument details modal not dismissing.

Risk assessment

low

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works nicely/as expected on the flex ODD. Desktop side drop tip also works as expected still.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. So much change for such a little problem

@mjhuff mjhuff merged commit 81770b3 into chore_release-8.0.0 Sep 17, 2024
26 checks passed
@mjhuff mjhuff deleted the app_fix-odd-drop-tip-modal-dismissal branch September 17, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants