Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): use critical point instead of primary nozzle when doing deck conflict check #16268

Merged

Conversation

sanni-t
Copy link
Member

@sanni-t sanni-t commented Sep 17, 2024

Closes RQA-3175

Overview

There was a bug in the deck conflict checker that it wasn't considering the change in critical point of pipette in use when addressing reservoirs. This was leading to incorrect conflict checks when moving to any labware that had the centerMultichannelOnWells quirk.

This PR fixes that by correctly finding the pipette's boundaries when its critical point is moved to the destination in question rather than its primary nozzle (the default critical point).

Test Plan and Hands on Testing

  • Added integration tests that uses reservoirs with row and channel configurations
  • Existing unit and integration tests should remain unaffected
  • Add tests for conflict checks with 8-channel pipette partial column configuration
  • Test on a robot that existing pipette movements with different pipettes in different configurations is not affected

Review requests

  • Make sure the logic checks out & test on robot

Risk assessment

Low. We have quite good test coverage for a lot of cases so any unexpected changes should get caught in the tests easily.

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really solid so far, thanks for the fast turnaround Sanniti! Passes analysis for Sara's protocol from the related ticket well and without issues.

@sanni-t sanni-t marked this pull request as ready for review September 17, 2024 20:09
@sanni-t sanni-t requested a review from a team as a code owner September 17, 2024 20:09
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chore_release-8.0.0@81770b3). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##             chore_release-8.0.0   #16268   +/-   ##
======================================================
  Coverage                       ?   63.28%           
======================================================
  Files                          ?      300           
  Lines                          ?    15786           
  Branches                       ?        0           
======================================================
  Hits                           ?     9990           
  Misses                         ?     5796           
  Partials                       ?        0           
Flag Coverage Δ
g-code-testing 92.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sanni-t sanni-t merged commit f77a962 into chore_release-8.0.0 Sep 17, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants