Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Fix liquidProbe error message after blowout #16294

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Sep 18, 2024

Overview

This is the error message fix part of RQA-3171.

Test Plan and Hands on Testing

from opentrons import protocol_api


requirements = {"robotType": "Flex", "apiLevel": "2.20"}


def run(protocol: protocol_api.ProtocolContext):
    reservoir = protocol.load_labware("agilent_1_reservoir_290ml", "A1")
    tip_rack = protocol.load_labware("opentrons_flex_96_filtertiprack_1000ul", "A2")

    pipette = protocol.load_instrument(
        "flex_1channel_1000", mount="left", tip_racks=[tip_rack]
    )

    trashbin = protocol.load_trash_bin("A3")

    # disable liquid presence detection on the pipette
    pipette.liquid_presence_detection = False

    # dry aspirate to prove it is off
    protocol.comment(f"Reservoir in {reservoir.parent} is to have NO liquid")
    pipette.pick_up_tip()
    pipette.aspirate(1000, reservoir["A1"])

    pipette.blow_out(trashbin)

    protocol.comment(f"Current volume in pipette: {pipette.current_volume}")  # prints 0

    is_liquid_in_reservoir = pipette.detect_liquid_presence(reservoir["A1"])
    protocol.comment(f"Is there liquid in the reservoir? {is_liquid_in_reservoir}")
pipenv run opentrons_simulate rqa_3171.py

Before:

ProtocolCommandFailedError [line 37]: Error 4000 GENERAL_ERROR (ProtocolCommandFailedError): TipNotEmptyError: This operation requires a tip with no liquid in it.

After:

ProtocolCommandFailedError [line 37]: Error 4000 GENERAL_ERROR (ProtocolCommandFailedError): PipetteNotReadyToAspirateError: The pipette cannot probe liquid because of a previous blow out. Run a prepareToAspirate command in a safe place to reset the plunger.

Changelog

When we're not ready to do a liquidProbe, be a little bit finer-grained about why we're not ready. Give the "missing tip" case and "plunger not ready" case their own error messages.

Review requests

See comments below.

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested review from ryanthecoder and a team September 18, 2024 21:16
None, after blow-out and the plunger is in an unsafe position or drop-tip and there is no tip attached.
None, after blow-out and the plunger is in an unsafe position.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation correction, no behavioral change.

@SyntaxColoring SyntaxColoring marked this pull request as ready for review September 18, 2024 21:23
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner September 18, 2024 21:23
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit re: error message wording

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@SyntaxColoring SyntaxColoring merged commit 65b0d7f into chore_release-8.0.0 Sep 19, 2024
21 checks passed
@SyntaxColoring SyntaxColoring deleted the tip_empty_error branch September 19, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants