-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): Fix liquidProbe error message after blowout #16294
Conversation
None, after blow-out and the plunger is in an unsafe position or drop-tip and there is no tip attached. | ||
None, after blow-out and the plunger is in an unsafe position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation correction, no behavioral change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit re: error message wording
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you!
Overview
This is the error message fix part of RQA-3171.
Test Plan and Hands on Testing
Before:
After:
Changelog
When we're not ready to do a
liquidProbe
, be a little bit finer-grained about why we're not ready. Give the "missing tip" case and "plunger not ready" case their own error messages.Review requests
See comments below.
Risk assessment
Low.