fix(app): fix MoveInterventionModal labware begin location not updating properly

[mjhuff]

Closes RQA-3216

Overview

When the app is polling, and there are two back-to-back manual move interventions, the labware start location doesn't update correctly due to the memoization of some of the content and the way rendering works in React. For some reason, this problem does not seem to occur consistently when the app is on notifications (but it does occur sometimes).

Looking back when this memoization logic was initially added (which was long before the InterventionModal partial refactor), I don't think we really need it anymore. If anything, this child content should be made into its own component at some point.

As to why different texts seem to render at different timings, I think that has to do with some of the utility functions themselves...revisiting these would be a good idea in the future.

Current Behavior

2024-09-19_14-14-55.mp4

Fixed Behavior

Screen.Recording.2024-09-19.at.3.59.17.PM.mov

Test Plan and Hands on Testing

• Turn on polling in app settings > feature flags. This makes it easy to reproduce.
• Run a protocol with back-to-back manual move commands (see ticket for protocol).
• Validate the fix.

Changelog

• Fixed the initial labware location sometimes not displaying the correct location when running back to back manual move labware commands.

Risk assessment

low

[TamarZanzouri]

code changes LGTM!

[sfoster1]

any time we can remove a memo it's worth it