fix(app): fix MoveInterventionModal labware begin location not updating properly #16307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3216
Overview
When the app is polling, and there are two back-to-back manual move interventions, the labware start location doesn't update correctly due to the memoization of some of the content and the way rendering works in React. For some reason, this problem does not seem to occur consistently when the app is on notifications (but it does occur sometimes).
Looking back when this memoization logic was initially added (which was long before the
InterventionModal
partial refactor), I don't think we really need it anymore. If anything, this child content should be made into its own component at some point.As to why different texts seem to render at different timings, I think that has to do with some of the utility functions themselves...revisiting these would be a good idea in the future.
Current Behavior
2024-09-19_14-14-55.mp4
Fixed Behavior
Screen.Recording.2024-09-19.at.3.59.17.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low