test(ll): make cypress tests compatible with deployed environments #16405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed. Removed the mock and replaced with real file read. |
y3rsh
commented
Oct 3, 2024
shlokamin
approved these changes
Oct 18, 2024
Comment on lines
-10
to
-18
| const testAliases: {} | { 'file-saver': string } = | ||
| process.env.CYPRESS === '1' | ||
| ? { | ||
| 'file-saver': | ||
| path.resolve(__dirname, 'cypress/mocks/file-saver.js') ?? '', | ||
| } | ||
| : {} | ||
|
|
There was a problem hiding this comment.
these deletions make me so happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Labware Library Cypress tests were able to run locally and in CI but some patterns did not allow for the same test to execute against a deployed environment. Additionally there were no instructions or make targets to quickly run the tests against a deployed environment.
Test Plan and Hands on Testing
make -C labware-library test-e2e-remote REMOTE_BASE_URL='https://labware.opentrons.com'labware library e2e testsjob inLabware Library test, build, and deployproves the tests also still works against localhostReview requests
Risk assessment