Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data, labware-library): add deck riser definition and new Lid category to LL #16410

Merged
merged 13 commits into from
Oct 23, 2024

Conversation

syao1226
Copy link
Collaborator

@syao1226 syao1226 commented Oct 3, 2024

re AUTH-869, AUTH-892, PLAT-533, and AUTH-887

Overview

Adding a new deck riser definition with its image to shared data so it can be displayed in the Labware Library, and updating the TC lid definition to include a stacking offset for the deck riser. Also, adding a new 'Lid' category to the Labware Library for the TC auto-sealing lids.

Test Plan and Hands on Testing

  • Make sure the Opentrons Flex Deck Riser shows up in the Labware Library's "Adapter" category
  • Ensure that the “Lid” category appears on the left navigation of the Labware Library site
  • When the “Lid” category is selected, the Opentrons Tough PCR Auto-Sealing Lid appears in the search results

For testing deck riser definition on a Flex:

Changelog

  • Added the opentrons_flex_deck_riser definition to shared-data after tested it with TC lids on the Flex
  • Updated the opentrons_tough_pcr_auto_sealing_lid definition and added its image to LL
  • Updated files to include a 'Lid' category in LL

Review requests

Risk assessment

@syao1226 syao1226 changed the title feat(shared-data): add TC lid definition to LL feat(shared-data): add TC lid definition and new Lid category to LL Oct 7, 2024
@syao1226 syao1226 changed the title feat(shared-data): add TC lid definition and new Lid category to LL feat(shared-data, labware-library): add TC lid definition and new Lid category to LL Oct 7, 2024
@syao1226 syao1226 requested a review from sanni-t October 7, 2024 19:51
@syao1226 syao1226 marked this pull request as ready for review October 7, 2024 19:51
@syao1226 syao1226 requested review from a team as code owners October 7, 2024 19:51
@syao1226 syao1226 requested review from shlokamin and SyntaxColoring and removed request for a team October 7, 2024 19:51
@syao1226 syao1226 marked this pull request as draft October 16, 2024 19:33
@syao1226 syao1226 changed the title feat(shared-data, labware-library): add TC lid definition and new Lid category to LL feat(shared-data, labware-library): add deck riser, TC lid definition, and new Lid category to LL Oct 16, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.72%. Comparing base (7fb38c9) to head (581f911).
Report is 42 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #16410      +/-   ##
==========================================
+ Coverage   73.77%   74.72%   +0.95%     
==========================================
  Files          41       42       +1     
  Lines        2989     3118     +129     
==========================================
+ Hits         2205     2330     +125     
- Misses        784      788       +4     
Flag Coverage Δ
shared-data 74.72% <100.00%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...pentrons_shared_data/labware/labware_definition.py 100.00% <100.00%> (ø)
...data/python/opentrons_shared_data/labware/types.py 100.00% <ø> (ø)

@syao1226 syao1226 changed the title feat(shared-data, labware-library): add deck riser, TC lid definition, and new Lid category to LL feat(shared-data, labware-library): add deck riser definition and new Lid category to LL Oct 21, 2024
@syao1226 syao1226 marked this pull request as ready for review October 21, 2024 15:22
@syao1226 syao1226 assigned CaseyBatten and unassigned CaseyBatten Oct 21, 2024
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks straight forward to me, great work!

@@ -95,6 +95,7 @@ export const SINGLE_CHANNEL_COMPATIBLE_LABWARE = [
'opentrons/opentrons_flex_96_tiprack_1000ul/1',
'opentrons/opentrons_flex_96_tiprack_200ul/1',
'opentrons/opentrons_flex_96_tiprack_50ul/1',
'opentrons/opentrons_tough_pcr_auto_sealing_lid/1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@syao1226
Let's verify that the auto-sealing lid does not appear as selectable labware in the Quick Transfer flow. If it does appear, then I think the generateCompatibleLabwareForPipette utility needs to take into account lids or maybe this specific lid and possibly omit them from being added to the (SINGLE_CHANNEL_COMPATIBLE_LABWARE) array.

@smb2268
Is this accurate?

Copy link
Contributor

@smb2268 smb2268 Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, since this util is meant to return the labware that each pipette is able to aspirate/dispense into I think we should change the conditional on lines 16-17 of generateCompatibleLabwareForPipette to be:

        definition.allowedRoles != null &&
        (definition.allowedRoles.includes('adapter') || definition.allowedRoles.includes('lid'))

However, we do have an additional layer in the quick transfer flow that only shows labware with display categories reservoir, tubeRack, and wellPlate so the lid won't be displayed as an option regardless.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay i'll update generateCompatibleLabwareForPipette to omit lids. thanks!

Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me!

@vegano1 vegano1 self-requested a review October 22, 2024 23:50
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the quick transfer changes, this looks good ! Great work !

@syao1226 syao1226 merged commit bbe06f1 into edge Oct 23, 2024
48 checks passed
@syao1226 syao1226 deleted the shared_data-lid-definition branch October 23, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants