Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): get back unboxingFlow path update function #16411

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(app): get back unboxingFlow path update function #16411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/src/pages/RobotDashboard/WelcomeModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as React from 'react'
import { useTranslation } from 'react-i18next'
import { useDispatch } from 'react-redux'

import {
COLORS,
Expand All @@ -14,10 +15,12 @@ import { useCreateLiveCommandMutation } from '@opentrons/react-api-client'

import { SmallButton } from '../../atoms/buttons'
import { Modal } from '../../molecules/Modal'
import { updateConfigValue } from '../../redux/config'

import welcomeModalImage from '../../assets/images/on-device-display/welcome_dashboard_modal.png'

import type { SetStatusBarCreateCommand } from '@opentrons/shared-data'
import type { Dispatch } from '../../redux/types'

interface WelcomeModalProps {
setShowWelcomeModal: (showWelcomeModal: boolean) => void
Expand All @@ -27,6 +30,7 @@ export function WelcomeModal({
setShowWelcomeModal,
}: WelcomeModalProps): JSX.Element {
const { t } = useTranslation(['device_details', 'shared'])
const dispatch = useDispatch<Dispatch>()

const { createLiveCommand } = useCreateLiveCommandMutation()
const animationCommand: SetStatusBarCreateCommand = {
Expand All @@ -44,6 +48,12 @@ export function WelcomeModal({
}

const handleCloseModal = (): void => {
dispatch(
updateConfigValue(
'onDeviceDisplaySettings.unfinishedUnboxingFlowRoute',
null
)
)
setShowWelcomeModal(false)
}

Expand Down
7 changes: 6 additions & 1 deletion app/src/pages/RobotDashboard/__tests__/WelcomeModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ import { useCreateLiveCommandMutation } from '@opentrons/react-api-client'

import { renderWithProviders } from '../../../__testing-utils__'
import { i18n } from '../../../i18n'
import { updateConfigValue } from '../../../redux/config'
import { WelcomeModal } from '../WelcomeModal'

import type { SetStatusBarCreateCommand } from '@opentrons/shared-data'

vi.mock('../../../redux/config')
vi.mock('@opentrons/react-api-client')
vi.mock('../../../redux/config')

const mockFunc = vi.fn()
const WELCOME_MODAL_IMAGE_NAME = 'welcome_dashboard_modal.png'
Expand Down Expand Up @@ -61,6 +62,10 @@ describe('WelcomeModal', () => {
it('should call a mock function when tapping next button', () => {
render(props)
fireEvent.click(screen.getByText('Next'))
expect(vi.mocked(updateConfigValue)).toHaveBeenCalledWith(
'onDeviceDisplaySettings.unfinishedUnboxingFlowRoute',
null
)
expect(props.setShowWelcomeModal).toHaveBeenCalled()
})
})
Loading