Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): fully connected volume tracking #16532

Open
wants to merge 21 commits into
base: edge
Choose a base branch
from

Conversation

pmoegenburg
Copy link
Member

@pmoegenburg pmoegenburg commented Oct 18, 2024

Overview

This PR aims to consolidate well volume data from our existing relevant commands into a single source of truth in WellStore. These commands are LiquidProbe, LoadLiquid, Aspirate, and Dispense.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (9797d74) to head (d5f021d).
Report is 35 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #16532       +/-   ##
===========================================
+ Coverage   79.88%   92.43%   +12.55%     
===========================================
  Files         120       77       -43     
  Lines        4410     1283     -3127     
===========================================
- Hits         3523     1186     -2337     
+ Misses        887       97      -790     
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)
shared-data ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 43 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant