feat(opentrons-ai-client): Created the footer component with the privacy policy and EULA #16535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbelginetw
reviewed
Oct 18, 2024
| } | ||
| `; | ||
|
|
||
| const DISCLAIMER_TEXT_STYLE = css` |
There was a problem hiding this comment.
maybe we can use the styled component approach to keep consistency?
connected-znaim
changed the title
shlokamin
reviewed
Oct 21, 2024
Comment on lines
36
to
42
| const [ | ||
| firstPart, | ||
| privacyPolicy, | ||
| and, | ||
| EULA, | ||
| copyright, | ||
| ] = privacyPolicyText.split('\n') |
There was a problem hiding this comment.
you can use the Trans component in i18next so you dont have to split apart the text and feed it into different components:
https://react.i18next.com/latest/trans-component
so it would be something like this in the translation file:
{
"privacy_policy": "{{firstPart}} <privacyPolicyLink>Privacy Policy</privacyPolicyLink> {{and}} <EULALink>EULA</EULALink> {{copyright}}"
}and like this in your react component:
import { Trans, useTranslation } from 'react-i18next';
const { t } = useTranslation('protocol_generator');
<FooterText>
<Trans
i18nKey="privacy_policy"
components={{
privacyPolicyLink: (
<BlueLink
href="https://insights.opentrons.com/hubfs/Legal%20Documentation/Opentrons-Labworks-Privacy-Policy-5-4-23.docx-1.pdf"
target="_blank"
rel="noopener noreferrer"
/>
),
EULALink: (
<BlueLink
href="https://insights.opentrons.com/hubfs/Legal%20Documentation/Opentrons%20EULA%2020240710.pdf"
target="_blank"
rel="noopener noreferrer"
/>
)
}}
/>
<NewLineText>{t('copyright')}</NewLineText>
</FooterText>
fbelginetw
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test Plan and Hands on Testing
Manually tested both links
Changelog
The footer links to the following two urls:
Privacy policy:
"https://insights.opentrons.com/hubfs/Legal%20Documentation/Opentrons-Labworks-Privacy-Policy-5-4-23.docx-1.pdf"
EULA:
"https://insights.opentrons.com/hubfs/Legal%20Documentation/Opentrons%20EULA%2020240710.pdf"
Review requests
Risk assessment