Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abr-testing): Automated ABR data collection Make command #16548

Merged
merged 5 commits into from
Oct 21, 2024
Merged

feat(abr-testing): Automated ABR data collection Make command #16548

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec9c7f5
feat(abr-testing): Automated ABR data collection Make command
AnthonyNASC20 Oct 21, 2024
6a48d9c
feat(abr-testing): Automated ABR data collection Make command
AnthonyNASC20 Oct 21, 2024
2633162
feat(abr-testing): Automated ABR data collection Make command
AnthonyNASC20 Oct 21, 2024
24c5174
feat(abr-testing): Automated ABR data collection Make command
AnthonyNASC20 Oct 21, 2024
9bc5d82
feat(abr-testing): Automated ABR data collection Make command
AnthonyNASC20 Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions abr-testing/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,14 @@ push-no-restart-ot3: sdist Pipfile.lock

.PHONY: push-ot3
push-ot3: push-no-restart-ot3

.PHONY: abr-setup
abr-setup:
$(python) abr_testing/tools/abr_setup.py

.PHONY: simulate
PROTOCOL_DIR := abr_testing/protocols
SIMULATION_TOOL := protocol_simulation/abr_sim_check.py
EXTENSION := .py
simulate:
$(python) $(SIMULATION_TOOL)
11 changes: 2 additions & 9 deletions abr-testing/abr_testing/automation/google_sheets_tool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,20 +167,13 @@ def column_letter_to_index(column_letter: str) -> int:
self.spread_sheet.batch_update(body=body)
except gspread.exceptions.APIError as e:
print(f"ERROR MESSAGE: {e}")
raise

def update_cell(
self, sheet_title: str, row: int, column: int, single_data: Any
) -> Tuple[int, int, Any]:
"""Update ONE individual cell according to a row and column."""
try:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove error handling here

self.spread_sheet.worksheet(sheet_title).update_cell(
row, column, single_data
)
except gspread.exceptions.APIError:
t.sleep(30)
self.spread_sheet.worksheet(sheet_title).update_cell(
row, column, single_data
)
self.spread_sheet.worksheet(sheet_title).update_cell(row, column, single_data)
return row, column, single_data

def get_all_data(
Expand Down
Loading
Loading