Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): App support for downloading plate reader CSV files #16551

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Oct 21, 2024

fix PLAT-480, PLAT-485

Overview

Add csv files generated by plate reader to protocol file download section of run history on device details page and add banner on run history

Test Plan and Hands on Testing

Screen Shot 2024-10-21 at 2 12 48 PM

Screenshot 2024-10-18 at 12 15 16 PM

Changelog

  1. Add type for outputFileIds that will be returned from the server
  2. Display corresponding files in run history for download along with csv files from run time parameters
  3. Add banner in protocol run header that will tell users where to download files if they exist

Review requests

Review screenshots, this can be tested on any robot that has been updated with Casey's changes that were merged into edge d9f7d2a

Risk assessment

Low

@smb2268 smb2268 self-assigned this Oct 21, 2024
@smb2268 smb2268 marked this pull request as ready for review October 21, 2024 18:47
@smb2268 smb2268 requested a review from a team as a code owner October 21, 2024 18:47
Copy link
Contributor

@brenthagen brenthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, code LGTM !

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets 🚀!

@smb2268 smb2268 merged commit 0961a8b into edge Oct 21, 2024
14 checks passed
@smb2268 smb2268 deleted the app_csv-download-support branch October 21, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants