Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v3 alpha, fix) Update client remote to use MainRouter #359

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Oct 2, 2017

overview

#352 changed the shape of the RPC remote object. This PR fixes the client breakage due to that change. While I was here, I also fixed the API make install task, because it wasn't quite right.

This PR includes:

  • Chore work
  • Bug fixes
  • Backwards-compatible feature additions
  • Breaking changes
  • Documentation updates
  • Test updates

changelog

  • (Chore) Update API make install to use pip install -e .
  • (Fix) Update API client to expect opentrons.api.MainRouter as the remote object
  • (Tests) Update API client tests to for the above fix

review requests

I would love to merge this ASAP, so please review in the next 30 minutes. If you're on your phone, this PR is small enough that you should be able to review it from the mobile site without issue.

@mcous mcous changed the title (v3 alpha, fix) Update client remote to use MainRouter (v3 alpha, fix) Update client remote to use MainRouter Oct 2, 2017
@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #359 into app-3-0-alpha will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           app-3-0-alpha     #359   +/-   ##
==============================================
  Coverage          82.09%   82.09%           
==============================================
  Files                 86       86           
  Lines               4877     4877           
==============================================
  Hits                4004     4004           
  Misses               873      873
Impacted Files Coverage Δ
app/ui/robot/api-client/client.js 33.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e22ad...fdc5d14. Read the comment docs.

Copy link
Contributor

@Kadee80 Kadee80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcous mcous merged commit af5ebbc into app-3-0-alpha Oct 3, 2017
@mcous mcous deleted the v3a-feat-client-calibration branch October 3, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants