refactor(app): Allow app to request buildroot update token

app-shell/src/buildroot/index.js

@@ -47,6 +47,7 @@ export function registerBuildrootUpdate(dispatch: Dispatch) {
             .then(
               (): BuildrootAction => ({
                 type: 'buildroot:PREMIGRATION_DONE',
+                payload: robot.name,
               })
             )
             .catch(

app/src/components/RobotSettings/InformationCard.js

@@ -93,11 +93,11 @@ function makeMapStateToProps(): (state: State, ownProps: OP) => SP {
 
   return (state, ownProps) => {
     const version = getRobotApiVersion(ownProps.robot) || 'Unknown'
+
     return {
       version,
       updateInfo: getUpdateInfo(state, ownProps.robot),
-      buildrootUpdateAvailable:
-        version && getBuildrootUpdateAvailable(state, version),
+      buildrootUpdateAvailable: getBuildrootUpdateAvailable(state, version),
       __buildRootEnabled: Boolean(
         getConfig(state).devInternal?.enableBuildRoot
       ),

app/src/discovery/selectors.js

@@ -23,6 +23,7 @@ import type {
   Robot,
   ReachableRobot,
   UnreachableRobot,
+  ViewableRobot,
   AnyRobot,
   ConnectableStatus,
   ReachableStatus,
@@ -43,7 +44,7 @@ type GetConnectableRobots = Selector<State, void, Array<Robot>>
 type GetReachableRobots = Selector<State, void, Array<ReachableRobot>>
 type GetUnreachableRobots = Selector<State, void, Array<UnreachableRobot>>
 type GetAllRobots = Selector<State, void, Array<AnyRobot>>
-type GetLiveRobots = Selector<State, void, Array<Robot | ReachableRobot>>
+type GetLiveRobots = Selector<State, void, Array<ViewableRobot>>
 type GetConnectedRobot = Selector<State, void, ?Robot>
 
 export const CONNECTABLE: ConnectableStatus = 'connectable'
@@ -150,6 +151,7 @@ export const getRobotFirmwareVersion = (robot: AnyRobot): ?string =>
   (robot.health && robot.health.fw_version) ||
   (robot.serverHealth && robot.serverHealth.smoothieVersion)
 
+// TODO(mc, 2019-07-19): replace with selector(s) in app/src/shell/buildroot
 export const getRobotBuildrootStatus = (
   robot: AnyRobot
 ): BuildrootStatus | null => {
@@ -161,14 +163,14 @@ export const getRobotBuildrootStatus = (
     // migration capable proceed to step 2 automatically
     if (
       robot.serverHealth.capabilities &&
-      robot.serverHealth.capabilities['buildroot-migration']
+      robot.serverHealth.capabilities['buildrootMigration']
     ) {
       return 'migrating'
     }
     // robot is already on buildroot and capable of receiving normal buildroot updates
     if (
       robot.serverHealth.capabilities &&
-      robot.serverHealth.capabilities['buildroot-update']
+      robot.serverHealth.capabilities['buildrootUpdate']
     ) {
       return 'buildroot'
     }

app/src/epic.js

@@ -2,5 +2,6 @@
 // root application epic
 import { combineEpics } from 'redux-observable'
 import { robotApiEpic } from './robot-api'
+import { buildrootUpdateEpic } from './shell'
 
-export default combineEpics(robotApiEpic)
+export default combineEpics(robotApiEpic, buildrootUpdateEpic)

app/src/pages/Robots/RobotSettings.js

@@ -40,8 +40,8 @@ import ResetRobotModal from '../../components/RobotSettings/ResetRobotModal'
 
 import type { ContextRouter } from 'react-router'
 import type { State, Dispatch, Error } from '../../types'
-import type { ViewableRobot, BuildrootStatus } from '../../discovery'
-import type { ShellUpdateState } from '../../shell'
+import type { ViewableRobot } from '../../discovery'
+import type { ShellUpdateState, BuildrootStatus } from '../../shell'
 
 type WithRouterOP = {|
   robot: ViewableRobot,

app/src/robot-api/index.js

@@ -2,5 +2,7 @@
 export * from './types'
 export * from './resources'
 export * from './hooks'
+export * from './http'
+export * from './utils'
 
 export { robotApiReducer } from './reducer'

app/src/robot-api/utils.js

@@ -99,7 +99,7 @@ export const createBaseRobotApiEpic = (
     ofType(type),
     switchMap<RobotApiAction, _, _>(a =>
       // `any` typed to recast strictly-typed `meta` of RobotApiRequest
-      // to loosly-typed `meta` of RobotApi(Request|Response)Action
+      // to loosely-typed `meta` of RobotApi(Request|Response)Action
       makeRobotApiRequest(a.payload, (a: any).meta)
     )
   )

app/src/shell/buildroot/__tests__/actions.test.js

@@ -0,0 +1,33 @@
+import * as actions from '../actions'
+
+describe('app/shell/buildroot action creators', () => {
+  const SPECS = [
+    {
+      name: 'buildroot:SET_UPDATE_SEEN',
+      creator: actions.setBuildrootUpdateSeen,
+      args: [],
+      expected: { type: 'buildroot:SET_UPDATE_SEEN' },
+    },
+    {
+      name: 'buildroot:START_PREMIGRATION',
+      creator: actions.startBuildrootPremigration,
+      args: [{ name: 'robot', ip: '10.10.0.0', port: 31950 }],
+      expected: {
+        type: 'buildroot:START_PREMIGRATION',
+        payload: { name: 'robot', ip: '10.10.0.0', port: 31950 },
+        meta: { shell: true },
+      },
+    },
+    {
+      name: 'buildroot:UNEXPECTED_ERROR',
+      creator: actions.unexpectedBuildrootError,
+      args: [],
+      expected: { type: 'buildroot:UNEXPECTED_ERROR' },
+    },
+  ]
+
+  SPECS.forEach(spec => {
+    const { name, creator, args, expected } = spec
+    test(name, () => expect(creator(...args)).toEqual(expected))
+  })
+})