-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EH-1700: Give zero duration if jakso is not found from eHOKS #289
Conversation
cc39f2a
to
ec4b7c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jesjes.
@@ -42,7 +42,7 @@ | |||
kestot (nh/oppijan-jaksojen-kestot | |||
concurrent-jaksot opiskeluoikeudet) | |||
jakso-key (nh/ids jakso)] | |||
(if-let [new-kesto (get kestot jakso-key)] | |||
(if-let [new-kesto (get kestot jakso-key 0)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tää on sikäli bugialtista, että olis kuviteltavissa, että kestot-mapista puuttuu kyseinen avain jostain muusta syystä kuin siksi, että kesto yritettiin laskea mutta epäonnistuttiin. Mun puolesta näin voi tehdä, mutta enemmän eksplisiittisiä mahdollisuuksia olis esim. että oppijan-jaksojen-kestot
laittais kestot-mappiin jonku :jaksoa-ei-loydy
-keywordin numeron sijaan silloin ku laskennassa on joku ongelma.
Vakavuus: ehdotus
1f4d2df
to
c0fe972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Joo, tää on parannus.
(if-let [new-kesto (get kestot jakso-key)] | ||
jakso-key (nh/ids jakso) | ||
new-kesto | ||
(if (find-first #(= (:hankkimistapa_id %) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tähän käy myös some
, joka on semanttisesti lähempänä
vakavuus: idea
jakso-key (nh/ids jakso) | ||
new-kesto | ||
(if (find-first #(= (:hankkimistapa_id %) | ||
(:hankkimistapa_id jakso)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onko mahdollista, että nämä yhtaikaiset jaksot ovat eri HOKSeista? Silloin pitää verrata koko (nh/ids jakso)
:a.
vakavuus: jos on mahdollista että ovat eri HOKSeista, pyyntö.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kai se teoriassa on 🤔 Korjaan!
0bd92fc
to
51aedb2
Compare
51aedb2
to
67e671b
Compare
https://jira.eduuni.fi/browse/EH-1700