Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPHJOD-1044: Improve OpportunityCard accessibility for screenreader #276

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Nov 19, 2024

Description

  • Improves the OpportunityCard component's accessibility for screenreader by little.
  • Fixed typo in translation key name
  • Updated to use correct translation keys for trend icon
  • Fixed bug, where employment outlook dots where not showing correctly.

More info

Visual order should be same like before but when first arriving to the card, the heading is the first one to land (previously it landed on Favorite button).

Related JIRA ticket

https://jira.eduuni.fi/browse/OPHJOD-1044

@ketsappi ketsappi marked this pull request as ready for review November 19, 2024 11:03
@ketsappi ketsappi requested review from juhaniko and sauanto November 19, 2024 11:03
@ketsappi ketsappi merged commit e2c5b37 into main Nov 20, 2024
5 checks passed
@ketsappi ketsappi deleted the OPHJOD-1044 branch November 20, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants