Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPHJOD-1048: Fix accessability issues in tool #277

Merged
merged 1 commit into from
Nov 21, 2024
Merged

OPHJOD-1048: Fix accessability issues in tool #277

merged 1 commit into from
Nov 21, 2024

Conversation

juhaniko
Copy link
Contributor

@juhaniko juhaniko commented Nov 20, 2024 •
edited
Loading

Description

  • Update DS to fix a11y issues with Slider component
  • Darker color for helping tool icon for "Muu osaaminen"
  • AXE still reports a contrast issue with "Tyhjennä kaikki valitut osaamiset" button, but that's an issue with the DS button component with "gray-delete" variant. Will ask about this in the next PAMU session.

Related JIRA ticket

https://jira.eduuni.fi/browse/OPHJOD-1048

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@juhaniko juhaniko requested review from ketsappi and sauanto November 20, 2024 11:59
@juhaniko juhaniko merged commit 3418e7c into main Nov 21, 2024
5 checks passed
@juhaniko juhaniko deleted the OPHJOD-1048 branch November 21, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ketsappi ketsappi ketsappi approved these changes

@sauanto sauanto Awaiting requested review from sauanto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juhaniko @ketsappi