Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPHJOD-1067: Add filters and sorting to tool #288

Merged
merged 1 commit into from
Dec 4, 2024
Merged

OPHJOD-1067: Add filters and sorting to tool #288

merged 1 commit into from
Dec 4, 2024

Conversation

juhaniko
Copy link
Contributor

@juhaniko juhaniko commented Dec 3, 2024

Description

  • Added filtering and sorting to tool opportunities
  • Fixed a bug in OsaamisSuosittelija where it was possible to add duplicate skills
  • Clear button not implemented at this point
  • I decided to not show any numbers on the button, as it's kinda pointless since there's only 1 filter

Related JIRA ticket

https://jira.eduuni.fi/browse/OPHJOD-1067

image

<div className="text-form-label flex flex-row items-center gap-5">
<span className="font-arial">{t('do-filter')}</span>
<button
className="flex bg-white rounded-full relative size-6 justify-center items-center"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="flex bg-white rounded-full relative size-6 justify-center items-center"
className="flex bg-white rounded-full relative size-7 justify-center items-center"

{t('tool.your-opportunities.n-opportunities-found', { count })}
</span>
<div className="text-form-label flex flex-row items-center gap-5">
<span className="font-arial">{t('do-filter')}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A span could maybe also open the filters menu?

@juhaniko juhaniko merged commit 75a334e into main Dec 4, 2024
6 checks passed
@juhaniko juhaniko deleted the OPHJOD-1067 branch December 4, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants