Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPHJOD-1078: Add competence import dialog for Tool + confirm dialogs #290

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Dec 4, 2024

Description

  • Add competence import dialog for selecting what to import
  • Refactored code here and there to have it more reusable and readable
  • Add dialog for user that is not logged in; for import and export

Screenshots

Import

Not logged in

SCR-20241204-lowb

Logged in

SCR-20241204-lowb

Export

Not logged in

SCR-20241204-lowb

Logged in

SCR-20241204-lowb

Related JIRA ticket

https://jira.eduuni.fi/browse/OPHJOD-1078

@ketsappi ketsappi requested review from juhaniko and sauanto December 4, 2024 10:33
@ketsappi ketsappi force-pushed the OPHJOD-1078 branch 2 times, most recently from faeec77 to 5ea6ccd Compare December 4, 2024 11:04
@ketsappi ketsappi marked this pull request as ready for review December 4, 2024 11:06
Copy link

sonarqubecloud bot commented Dec 4, 2024

@ketsappi ketsappi merged commit f268857 into main Dec 5, 2024
6 checks passed
@ketsappi ketsappi deleted the OPHJOD-1078 branch December 5, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants