Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm chart for OES v3.5 release #96

Merged
merged 6 commits into from
Mar 1, 2021
Merged

Update helm chart for OES v3.5 release #96

merged 6 commits into from
Mar 1, 2021

Conversation

abhinaybyrisetty
Copy link
Contributor

No description provided.

Copy link
Contributor

@Nirmalyasen Nirmalyasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to understand the change.

Otherwise, LGTM

front50.yml:
artifactId: quay.io/opsmxpublic/ubi8-oes-front50:0.25.1-opa
artifactId: quay.io/opsmxpublic/ubi8-spin-front50:0.26.1-opa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why did we use the oes front50 earlier? Was it or the OPA policy while saving pipelines and now it is part of the regular spin image?

Copy link
Contributor Author

@abhinaybyrisetty abhinaybyrisetty Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is if we are building the images with the customized changes from our forked repo, they should be pushed to the repo ubi8-oes-<service>:<tag>, and if images are built from open source code without any customizations using ubi8 base image, they should be pushed to the repo ubi8-spin-<service>:<tag>
Correct me if my understanding is wrong.

In this case, I think image was pushed to ubi8-spin-front50 instead of pushing it to ubi8-oes-front50.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed this, image is now ubi8-oes-front50:0.26.1

Copy link
Collaborator

@ksrinimba ksrinimba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets merge.

@abhinaybyrisetty abhinaybyrisetty merged commit 5900b49 into master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants