Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-22435: Bugfix spin cli trigger a pipeline user is admin or not for custom gate. #482

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

emanipravallika
Copy link
Collaborator

https://devopsmx.atlassian.net/browse/OP-22435

CodeChanges - As ISD is not aware of the usergroups/roles of x509 users. But in fiat, they're recognized as admin users,
hence skipping the validation for x509-users in ISD.
Added logs in all interceptors prehandle methods for clear debugging.

Copy link
Collaborator

@sudhakaropsmx sudhakaropsmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sudhakaropsmx sudhakaropsmx merged commit 9792389 into v4.0.3.1-wu Sep 13, 2024
1 check failed
@sudhakaropsmx sudhakaropsmx deleted the OP-22435-webhookTrigger branch September 13, 2024 04:45
@sudhakaropsmx sudhakaropsmx changed the title OP-22435: BugFix-WU-webhook-trigger for x509-admin users on skipping the validation in ISD. OP-22435: Bugfix spin cli trigger a pipeline user is admin or not for custom gate. Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants