Dark mode: Tables #2349
Merged
Dark mode: Tables #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
added
the
color mode
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
louismaximepiton
force-pushed
the
main-lmp-table-dark
branch
from
d7a5d92
to
78fb42c
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
2 times, most recently
from
03af5c3
to
f49a3ee
Compare
julien-deramond
force-pushed
the
main-lmp-table-dark
branch
from
247f532
to
6965621
Compare
julien-deramond
force-pushed
the
main-jd-dark-mode
branch
2 times, most recently
from
35328ca
to
f0b8a1e
Compare
julien-deramond
force-pushed
the
main-lmp-table-dark
branch
from
6965621
to
2e31f74
Compare
| @@ -150,6 +150,10 @@ | |||
| --#{$prefix}icon-filter: none; | |||
| --#{$prefix}select-indicator: #{$form-select-indicator}; | |||
| --#{$prefix}select-disabled-indicator: #{$form-select-disabled-indicator}; | |||
| --#{$prefix}table-striped-bg-factor: #{$table-striped-bg-factor}; | |||
There was a problem hiding this comment.
We'll see that at the end of the process of migrating everything, but these variables will probably end up in _tables.scss.
|
The icon should be white in this case, isn't it?
|
| @@ -914,7 +914,7 @@ Use SVG or PNG to display icons or thumbnails in your compact table data cell el | |||
| </div> | |||
| </td> | |||
| <td> | |||
| <img src="/docs/{{< param docs_version >}}/assets/img/thumbnail.png" alt="Thumbnail" width="30" height="30" class="me-2"> | |||
| <img style="filter: var(--bs-icon-filter)" src="/docs/{{< param docs_version >}}/assets/img/thumbnail.png" alt="Thumbnail" width="30" height="30" class="me-2"> | |||
There was a problem hiding this comment.
Do we need to say something about it in the documentation, or move on to a real SVG?
julien-deramond
approved these changes
Nov 6, 2023
Merged
julien-deramond
added a commit
that referenced
this pull request
Nov 7, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 10, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 29, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 4, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 8, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 18, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 21, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 26, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Dec 27, 2023
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond
added a commit
that referenced
this pull request
Jan 2, 2024
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#141414or#000000in dark mode..table-activeis the most important state or the:hoverstate..bg-transparenton it.Tables in dark mode, by using existing Sass vars :
$table-bgvar(--#{$prefix}body-bg)transparent$table-striped-bg$table-striped-bg-factorvar(--#{$prefix}table-striped-bg-factor)$table-striped-hover-color$table-colorvar(--#{$prefix}black)$table-striped-hover-bg$table-striped-hover-bg-factorvar(--#{$prefix}table-striped-hover-bg-factor)$table-active-color$table-colorvar(--#{$prefix}black)$table-active-bg$table-active-bg-factorvar(--#{$prefix}table-active-bg-factor)$table-hover-bg$table-hover-bg-factorvar(--#{$prefix}table-hover-bg-factor)--bs-table-striped-hover-bg-factor$table-striped-hover-bg-factor.855--bs-table-striped-bg-factor$table-hover-bg-factor.135--bs-table-hover-bg-factor$table-hover-bg-factor.135--bs-table-active-bg-factor$table-active-bg-factor.565Links