This repository has been archived by the owner on Oct 20, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Refactor makefiles and do some cleaning #119
Merged
Orange-cscetbon
merged 14 commits into
Orange-OpenSource:master
from
cscetbon:makefile-update
Oct 18, 2019
Merged
Refactor makefiles and do some cleaning #119
Orange-cscetbon
merged 14 commits into
Orange-OpenSource:master
from
cscetbon:makefile-update
Oct 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscetbon
force-pushed
the
makefile-update
branch
2 times, most recently
from
October 6, 2019 20:12
87df3d1
to
8e54ce5
Compare
allamand
reviewed
Oct 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this ?
allamand
reviewed
Oct 11, 2019
Blocked due to free-plan-docker-layer-caching-unavailable |
cscetbon
force-pushed
the
makefile-update
branch
from
October 18, 2019 02:10
d97732d
to
0f833ae
Compare
allamand
previously approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if tests are ok :)
allamand
approved these changes
Oct 18, 2019
cscetbon
pushed a commit
that referenced
this pull request
Aug 13, 2020
Refactor makefiles and do some cleaning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.